Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4615 +/- ##
=======================================
Coverage ? 43.80%
=======================================
Files ? 278
Lines ? 16943
Branches ? 0
=======================================
Hits ? 7422
Misses ? 9521
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unit tests to validate AppIcon behavior, focusing on title availability, dark-mode asset selection, and default icon selection logic based on app configuration.
Changes:
- Added a test ensuring all
AppIconcases return a non-emptytitle. - Added tests for
darkIconmapping for shared vs per-icon dark assets. - Added a test covering
.debugdefault icon selection behavior (isDefault/iconName).
Comment on lines
+6
to
+10
| @Test func testAllIconsHaveLocalizedTitles() async throws { | ||
| #expect(AppIcon.allCases.count == 25) | ||
|
|
||
| for icon in AppIcon.allCases { | ||
| #expect(icon.title.isEmpty == false, "\(icon.rawValue) should have a localized title") |
| } | ||
|
|
||
| @Test func testDebugConfigurationSelectsDevAsDefaultIcon() async throws { | ||
| #expect(Current.appConfiguration == .debug) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppIcontitle mapping across all casesdarkIconbehavior for shared and per-icon assetsisDefaultandiconName